Resolved issue #3359 by timstableford · Pull Request #6969 · esp8266/Arduino (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logically seems fine. I appreciate that the default behavior is preserved.

My one request/niggle is that, instead of sever the new method/private be named close (closeConnectionsOnUpdate, _closeConnectionsOnUpdate) just for sanity's sake. sever and server look very much alike, and we use the term close for all methods which close TCP connections, not sever

Also, please add a little note about this new method in doc/ota_updates with @igrr's warning and your use case. OTW It's rather hard for someone to figure out what/why to use this...