Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits12 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

For SDFS and LittleFS, enable a creation time accessor for files and Dir
iterators, similar to the existing fileTime/getLastWrite calls.

Remove spurious Dir::getLastWrite method (the proper and only documented
way is really Dir::fileTime).

Update json to point to new mklittlefs which copies the creation date of
files to the image.

Fixes #6992

For SDFS and LittleFS, enable a creation time accessor for files and Dir iterators, similar to the existing fileTime/getLastWrite calls.

Remove spurious Dir::getLastWrite method (the proper and only documented way is really Dir::fileTime).

Update json to point to new mklittlefs which copies the creation date of files to the image.

Fixes esp8266#6992

LFS filenames are limited in size and generally very small. Use a stack variable instead of a dynamic allocation when performing full-path computations.

Per review, getCreation -> getCreationTime, fileCreation -> fileCreationTime.

The names fileTime() and getLastWrite() are inherited from ESP32 implementation and unchanged.

SdFat requries the dateTimeCallback call (global for everything) to update dates and times on created files.

Because the callback signature doesn't have space for us to provide any parameters, we cannot get the the File, Dir, or FS object's dateTimeCB member. Instead, just go with time(null) as the callback function which is right in all but the most esoteric cases.

2 participants