Pull GPIO initialization into its own 'weak' function. by everslick · Pull Request #7044 · esp8266/Arduino (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes. Fixes #7041.
By pulling GPIO init into its own weak function, it can be overridden by the user. This is important in cases when GPIOs should not toggle during reboot, exceptions or other crashes. Fixes #7041.
@everslick
Will you fix this error ?
core_esp8266_wiring_digital.cpp: In function 'void initPins()':
core_esp8266_wiring_digital.cpp:254:13: error: 'resetPins' was not declared in this scope
resetPins();
^
I think it is only the missing prototype void resetPins(); in wiring_private.h. I submitted the PR via the github online editor. , which only allows me to change ONE file per PR (I think).
Unfortunately I'm not at my workstation for at least 3 days. If it is not a big hassle to you I'd kindly ask you (@d-a-v) to add the line this time.
I just added the missing line to patch-4 and made a new PR. Lets see if the CI build succeeds now....
2 participants
