Netump Initial commit by hreintke · Pull Request #7527 · esp8266/Arduino (original) (raw)

Reply to comments @d-a-v @devyte

On default constructor/deconstructor being generated by compiler.
Need to include when there are also other (de)constructors, even when empty.

PacketType destructor
No need for this, if the destructor is the default (empty body in the cpp)

Done

PacketType constructor

Needed -> Not done

ntoh16
I meant: rather than reimplement here, why not call the lwip functions directly? or wrap the lwip calls in these methods.

These are netdump specific. wrapping lwip calls only complicates the code.
Not done

NetdumpIP
What I mean is that there doesn't seem to be an equivalent for IPv6, and also: is this constructor valid for the case of a sketch with only IPv6? If the answer to that is "no", then should the constructor have different args? have an overload with different args? something else?

NetdumpIP is created because lwip callback ans as such netdump always will have both IPv4 ans IPv6. Regardless of the lwip seting.
No change

Netdump IP (de)constructor.

Constructor needed -> not done
Deconstructor -> done

tcpBufferSize* (uppercase S)

Done

Does it also not apply to WiFiClientSecure?

Do not understand your comment.

Given that what comes next is an infinite loop, I suggest: "WiFiFailed, stopping sketch". I've been confused by these things myself.

Done

The switch was changed, but the arg is still received as an int.

Done