BREAKING: Add Print::availableForWrite method by earlephilhower · Pull Request #7658 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits6 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

earlephilhower

Adds an availableForWrite() method to the Print class, matching current
ArduinoCore-API commit 398e70f188e2b861c10d9ffe5e2bfcb6a4a4f489 .

Hook availableForWrite into the SDFS filesystem (other FSes don't have
this capability built-in).

Fixes #7650

@earlephilhower

Adds an availableForWrite() method to the Print class, matching current ArduinoCore-API commit 398e70f188e2b861c10d9ffe5e2bfcb6a4a4f489 .

Hook availableForWrite into the SDFS filesystem (other FSes don't have this capability built-in).

Fixes esp8266#7650

@earlephilhower

@earlephilhower

@earlephilhower earlephilhower changed the titleAdd Print::availableForWrite method BREAKING: Add Print::availableForWrite method

Oct 17, 2020

@earlephilhower

This is evidently a breaking change due to the type difference. Arduino's availableForWrite returns an int, while the (multiply-implemented, non-virtual) core availableForWrite returned size_t.

@earlephilhower

d-a-v

d-a-v

@d-a-v

@d-a-v d-a-v mentioned this pull request

Nov 6, 2020

2 participants

@earlephilhower @d-a-v