Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite by d-a-v · Pull Request #7935 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Should fix #7928

In the following code

        //if (_byteAddressable)
        //    return _peekPointer < _size ? _buffer[_peekPointer++] : -1;
        return _peekPointer < _size ? pgm_read_byte(&_buffer[_peekPointer++]) : -1;

I wonder if it is worth uncommenting the two first lines, which are valid.

d-a-v mentioned this pull request

Mar 23, 2021

I wonder if it is worth uncommenting the two first lines, which are valid.

I'd say no. Code size increase and pgm_read_byte is only 4 insns extra, anyway, so performance vs. the virtual call overhead should be nothing.

d-a-v changed the title~~StreamConstPtr: fix doc + reading flash space byte-by-byte~~ Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite

Stream::Send fixes: doc + StreamConstPtr byte-by-byte + missing SSL availableForWrite by d-a-v · Pull Request #7935 · esp8266/Arduino (original) (raw)

Conversation

Choose a reason for hiding this comment