Heap panic / abort cleanup by mhightower83 · Pull Request #8465 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

mhightower83

Isolate NULL/panic test of _context to dev debug assert macro.

Use abort instead of panic for the case of the caller providing a non-heap address pointer.

@mhightower83

Isolate NULL/panic test of _context to dev debug assert macro.

Use abort instead of panic for case of caller providing non-heap address pointer. Added debug print. Improved get_unpoisoned_check_neighbors to print file/line when available.

@mhightower83

d-a-v

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps at me in this code simplification.
Thank you for keeping improving the undergrounds and UMM

@d-a-v d-a-v added this to the 3.1 milestone

Feb 15, 2022

@d-a-v

@mcspr

Should be ok to merge then?

@mcspr

@mcspr

hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request

Nov 18, 2024

@mhightower83 @hasenradball

Isolate NULL/panic test of _context to dev debug assert macro.

Use abort instead of panic for case of caller providing non-heap address pointer. Added debug print. Improved get_unpoisoned_check_neighbors to print file/line when available.

Labels

alpha

included in alpha release