Board ID as build flag by mcspr · Pull Request #8634 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Use {_id} in mDNS response instead of the {build.board}, adds extra build flag -DARDUINO_BOARD_ID="{_id}"

For example

$ arduino-cli.exe board list
Port          Protocol Type              Board Name                FQBN                       Core
xxx.xxx.x.xxx network  Network Port      LOLIN(WEMOS) D1 R2 & mini esp8266com:esp8266:d1_mini esp8266com:esp8266

resolve #7759

When using IDE or arduino-cli board list, show full board name and FQBN

$ arduino-cli.exe board list
Port          Protocol Type              Board Name                FQBN                       Core
xxx.xxx.x.xxx network  Network Port      LOLIN(WEMOS) D1 R2 & mini esp8266com:esp8266:d1_mini esp8266com:esp8266

Also add description field to the mDNS response containing the original {build.board} string value.

resolve esp8266#7759

...or, just replace the {build.board} with {_id}. without adding yet another flag
just not sure whether changing its value matters anywhere but the IDE discovery, or if any user code might expect / use it in any way

mcspr deleted the mdns/board-id-and-desc branch

July 27, 2022 21:33

mcspr added this to the 3.1 milestone

Nov 2, 2022

hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request

Nov 18, 2024

Board ID as build flag

When using IDE or arduino-cli board list, show full board name and FQBN

$ arduino-cli.exe board list
Port          Protocol Type              Board Name                FQBN                       Core
xxx.xxx.x.xxx network  Network Port      LOLIN(WEMOS) D1 R2 & mini esp8266com:esp8266:d1_mini esp8266com:esp8266

Also add description field to the mDNS response containing the original {build.board} string value.

resolve esp8266#7759

does not work with recent ide (?)
fixup! does not work with recent ide (?)

2 participants