Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

re-use SdFat access mode through static const, no need to hard-code our own value w/ cast in the macro
separate access-modes from flags
simple compile-time tests in .cpp

resolve #8831

re-use SdFat value through static const, no need to hard-code our values w/ cast in the macro
separate read-modes from flags
simple compile-time tests in .cpp

resolve esp8266#8831

Does the mode change that I think I saw #8831 request break existing code and Arduino compatibility? The SD.h stuff has been untouched since #5525, over 4 years ago, pre 3.x even.

OTW, neat use of static_asserts!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice debug.
Reason is: upstream O_READ was 1 and now is 0 since our release v3.
Thanks

mcspr changed the title~~SdFat <-> FS HAL mode fixes & test~~ SdFat -> FS HAL mode fixes & test

Jan 31, 2023

mcspr deleted the sdfs/mode-oops branch

January 31, 2023 19:28

earlephilhower added a commit to earlephilhower/arduino-pico that referenced this pull request

Feb 11, 2023

earlephilhower added a commit to earlephilhower/arduino-pico that referenced this pull request

Feb 11, 2023

hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request

Nov 18, 2024

re-use SdFat access mode through static const, no need to hard-code our own value w/ cast in the macro
separate read-modes from flags; read, write and rw are distinct numbers
simple compile-time tests in .cpp

resolve esp8266#8831

Labels

alpha

included in alpha release