feat(matter): adds a Pressure Sensor Matter Endpoint by SuGlider · Pull Request #10710 · espressif/arduino-esp32 (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits3 Checks55 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Description of Change
Adds a Pressure Sensor Matter Endpoint.
It work like all other sensors by reporting to the Matter Controller the pressure read by the device.
Tested with Home Assistant + Matter Plugin
Note: This endpoint is not supported by some Matter Providers, such as Amazon Alexa and Apple HomeKit
Tests scenarios
ESP32-C6 using the provided example
Related links
Related to #7432
| Warnings | |
|---|---|
| ⚠️ | The **target branch** for this Pull Request **must be the default branch** of the project (`master`). If you would like to add this feature to a different branch, please state this in the PR description and we will consider it. |
| Messages | |
|---|---|
| 📖 | You might consider squashing your 3 commits (simplifying branch history). |
👋 Hello SuGlider, we appreciate your contribution to this project!
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by 🚫 dangerJS against 56a9b1d
Memory usage test (comparing PR against master branch)
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
| Memory | FLASH [bytes] | FLASH [%] | RAM [bytes] | RAM [%] | ||||
|---|---|---|---|---|---|---|---|---|
| Target | DEC | INC | DEC | INC | DEC | INC | DEC | INC |
| ESP32S3 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32S2 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32C3 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32C6 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32 | 0 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
Click to expand the detailed deltas report [usage change in BYTES]
| Target | ESP32S3 | ESP32S2 | ESP32C3 | ESP32C6 | ESP32 | |||||
|---|---|---|---|---|---|---|---|---|---|---|
| Example | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM |
| Matter/examples/MatterColorLight | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterCommissionTest | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterComposedLights | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterDimmableLight | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterEnhancedColorLight | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterFan | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterHumiditySensor | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterMinimum | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterOnOffLight | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterPressureSensor | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterSmartButon | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterTemperatureLight | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/MatterTemperatureSensor | - | - | - | - | - | - | - | - | - | - |
| Matter/examples/WiFiProvWithinMatter | - | - | - | - | - | - | - | - | - | - |
Test Results
62 files 62 suites 5m 40s ⏱️
21 tests 21 ✅ 0 💤 0 ❌
154 runs 154 ✅ 0 💤 0 ❌
Results for commit 56a9b1d.
♻️ This comment has been updated with latest results.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
