fix(logging): incorrect FPS logging by TNeutron · Pull Request #10921 · espressif/arduino-esp32 (original) (raw)

Dear @me-no-dev
I have reverted and added the change as you mentioned.

Both FPS and Avg FPS is correct now.
Here is the log camera stream log taken from this commit -

14:51:03.753 -> [ 10931][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 47ms (21.3fps), AVG: 32ms (31.2fps)
14:51:03.753 -> [ 10955][I][app_httpd.cpp:290] stream_handler(): MJPG: 6176B 24ms (41.7fps), AVG: 32ms (31.2fps)
14:51:03.785 -> [ 10988][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 32ms (31.2fps), AVG: 33ms (30.3fps)
14:51:03.829 -> [ 11008][I][app_httpd.cpp:290] stream_handler(): MJPG: 6606B 19ms (52.6fps), AVG: 30ms (33.3fps)
14:51:03.862 -> [ 11064][I][app_httpd.cpp:290] stream_handler(): MJPG: 6606B 56ms (17.9fps), AVG: 32ms (31.2fps)
14:51:03.902 -> [ 11081][I][app_httpd.cpp:290] stream_handler(): MJPG: 6606B 16ms (62.5fps), AVG: 31ms (32.3fps)
14:51:03.902 -> [ 11112][I][app_httpd.cpp:290] stream_handler(): MJPG: 7081B 30ms (33.3fps), AVG: 31ms (32.3fps)
14:51:03.935 -> [ 11134][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 22ms (45.5fps), AVG: 31ms (32.3fps)
14:51:03.981 -> [ 11163][I][app_httpd.cpp:290] stream_handler(): MJPG: 7074B 28ms (35.7fps), AVG: 31ms (32.3fps)
14:51:04.028 -> [ 11210][I][app_httpd.cpp:290] stream_handler(): MJPG: 7074B 47ms (21.3fps), AVG: 32ms (31.2fps)
14:51:04.072 -> [ 11282][I][app_httpd.cpp:290] stream_handler(): MJPG: 5928B 71ms (14.1fps), AVG: 34ms (29.4fps)
14:51:04.150 -> [ 11338][I][app_httpd.cpp:290] stream_handler(): MJPG: 6073B 56ms (17.9fps), AVG: 34ms (29.4fps)
14:51:04.191 -> [ 11400][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 61ms (16.4fps), AVG: 36ms (27.8fps)
14:51:04.227 -> [ 11424][I][app_httpd.cpp:290] stream_handler(): MJPG: 6471B 24ms (41.7fps), AVG: 35ms (28.6fps)
14:51:04.274 -> [ 11455][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 30ms (33.3fps), AVG: 34ms (29.4fps)
14:51:04.311 -> [ 11501][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 45ms (22.2fps), AVG: 35ms (28.6fps)
14:51:04.311 -> [ 11521][I][app_httpd.cpp:290] stream_handler(): MJPG: 6769B 20ms (50.0fps), AVG: 34ms (29.4fps)
14:51:04.351 -> [ 11544][I][app_httpd.cpp:290] stream_handler(): MJPG: 8132B 22ms (45.5fps), AVG: 35ms (28.6fps)
14:51:04.383 -> [ 11576][I][app_httpd.cpp:290] stream_handler(): MJPG: 6473B 31ms (32.3fps), AVG: 35ms (28.6fps)
14:51:04.383 -> [ 11593][I][app_httpd.cpp:290] stream_handler(): MJPG: 7084B 16ms (62.5fps), AVG: 34ms (29.4fps)
14:51:04.419 -> [ 11628][I][app_httpd.cpp:290] stream_handler(): MJPG: 9427B 35ms (28.6fps), AVG: 34ms (29.4fps)
14:51:04.459 -> [ 11647][I][app_httpd.cpp:290] stream_handler(): MJPG: 8255B 19ms (52.6fps), AVG: 34ms (29.4fps)
14:51:04.505 -> [ 11681][I][app_httpd.cpp:290] stream_handler(): MJPG: 7861B 33ms (30.3fps), AVG: 34ms (29.4fps)
14:51:04.537 -> [ 11742][I][app_httpd.cpp:290] stream_handler(): MJPG: 7000B 60ms (16.7fps), AVG: 36ms (27.8fps)
14:51:04.570 -> [ 11774][I][app_httpd.cpp:290] stream_handler(): MJPG: 7000B 32ms (31.2fps), AVG: 34ms (29.4fps)
14:51:04.603 -> [ 11794][I][app_httpd.cpp:290] stream_handler(): MJPG: 7000B 20ms (50.0fps), AVG: 35ms (28.6fps)
14:51:04.603 -> [ 11810][I][app_httpd.cpp:290] stream_handler(): MJPG: 7861B 16ms (62.5fps), AVG: 34ms (29.4fps)
14:51:04.637 -> [ 11847][I][app_httpd.cpp:290] stream_handler(): MJPG: 6059B 36ms (27.8fps), AVG: 35ms (28.6fps)
14:51:04.673 -> [ 11866][I][app_httpd.cpp:290] stream_handler(): MJPG: 6533B 19ms (52.6fps), AVG: 34ms (29.4fps)
14:51:04.705 -> [ 11898][I][app_httpd.cpp:290] stream_handler(): MJPG: 6874B 31ms (32.3fps), AVG: 33ms (30.3fps)
14:51:04.705 -> [ 11914][I][app_httpd.cpp:290] stream_handler(): MJPG: 7060B 16ms (62.5fps), AVG: 31ms (32.3fps)
14:51:04.741 -> [ 11951][I][app_httpd.cpp:290] stream_handler(): MJPG: 7060B 36ms (27.8fps), AVG: 30ms (33.3fps)
14:51:04.781 -> [ 11971][I][app_httpd.cpp:290] stream_handler(): MJPG: 8641B 19ms (52.6fps), AVG: 28ms (35.7fps)
14:51:04.827 -> [ 12001][I][app_httpd.cpp:290] stream_handler(): MJPG: 7287B 30ms (33.3fps), AVG: 28ms (35.7fps)
14:51:04.871 -> [ 12060][I][app_httpd.cpp:290] stream_handler(): MJPG: 6910B 59ms (16.9fps), AVG: 29ms (34.5fps)
14:51:04.871 -> [ 12081][I][app_httpd.cpp:290] stream_handler(): MJPG: 6910B 20ms (50.0fps), AVG: 28ms (35.7fps)
14:51:04.904 -> [ 12103][I][app_httpd.cpp:290] stream_handler(): MJPG: 7468B 21ms (47.6fps), AVG: 28ms (35.7fps)
14:51:04.937 -> [ 12139][I][app_httpd.cpp:290] stream_handler(): MJPG: 7923B 36ms (27.8fps), AVG: 29ms (34.5fps)
14:51:05.012 -> [ 12195][I][app_httpd.cpp:290] stream_handler(): MJPG: 6339B 56ms (17.9fps), AVG: 30ms (33.3fps)
14:51:05.012 -> [ 12216][I][app_httpd.cpp:290] stream_handler(): MJPG: 5950B 20ms (50.0fps), AVG: 30ms (33.3fps)
14:51:05.089 -> [ 12298][I][app_httpd.cpp:290] stream_handler(): MJPG: 6681B 82ms (12.2fps), AVG: 33ms (30.3fps)
14:51:05.131 -> [ 12318][I][app_httpd.cpp:290] stream_handler(): MJPG: 7029B 19ms (52.6fps), AVG: 33ms (30.3fps)
14:51:05.209 -> [ 12389][I][app_httpd.cpp:290] stream_handler(): MJPG: 7029B 71ms (14.1fps), AVG: 34ms (29.4fps)
14:51:05.209 -> [ 12412][I][app_httpd.cpp:290] stream_handler(): MJPG: 7923B 22ms (45.5fps), AVG: 33ms (30.3fps)
14:51:05.245 -> [ 12437][I][app_httpd.cpp:290] stream_handler(): MJPG: 6174B 25ms (40.0fps), AVG: 32ms (31.2fps)
14:51:05.245 -> [ 12454][I][app_httpd.cpp:290] stream_handler(): MJPG: 6791B 17ms (58.8fps), AVG: 32ms (31.2fps)
14:51:05.277 -> [ 12481][I][app_httpd.cpp:290] stream_handler(): MJPG: 6015B 26ms (38.5fps), AVG: 33ms (30.3fps)
14:51:05.313 -> [ 12523][I][app_httpd.cpp:290] stream_handler(): MJPG: 6928B 41ms (24.4fps), AVG: 33ms (30.3fps)
14:51:05.347 -> [ 12556][I][app_httpd.cpp:290] stream_handler(): MJPG: 9079B 33ms (30.3fps), AVG: 34ms (29.4fps)
14:51:05.392 -> [ 12579][I][app_httpd.cpp:290] stream_handler(): MJPG: 7613B 22ms (45.5fps), AVG: 33ms (30.3fps)
14:51:05.424 -> [ 12603][I][app_httpd.cpp:290] stream_handler(): MJPG: 7613B 24ms (41.7fps), AVG: 33ms (30.3fps)
14:51:05.424 -> [ 12626][I][app_httpd.cpp:290] stream_handler(): MJPG: 8491B 22ms (45.5fps), AVG: 33ms (30.3fps)
14:51:05.461 -> [ 12653][I][app_httpd.cpp:290] stream_handler(): MJPG: 7453B 26ms (38.5fps), AVG: 33ms (30.3fps)
14:51:05.461 -> [ 12670][I][app_httpd.cpp:290] stream_handler(): MJPG: 6488B 17ms (58.8fps), AVG: 32ms (31.2fps)
14:51:05.498 -> [ 12690][I][app_httpd.cpp:290] stream_handler(): MJPG: 7441B 19ms (52.6fps), AVG: 30ms (33.3fps)
14:51:05.498 -> [ 12707][I][app_httpd.cpp:290] stream_handler(): MJPG: 7029B 17ms (58.8fps), AVG: 30ms (33.3fps)
14:51:05.577 -> [ 12757][I][app_httpd.cpp:290] stream_handler(): MJPG: 7029B 49ms (20.4fps), AVG: 32ms (31.2fps)
14:51:05.622 -> [ 12788][I][app_httpd.cpp:290] stream_handler(): MJPG: 8170B 31ms (32.3fps), AVG: 31ms (32.3fps)
14:51:05.669 -> [ 12833][I][app_httpd.cpp:290] stream_handler(): MJPG: 6402B 45ms (22.2fps), AVG: 31ms (32.3fps)

I'm still learning my way around git. Again, I appreciate your patience and kind response :) Looking forward to the merge 😅