fix(camera_webserver): Fix typo in OV2640 definition by lucasssvaz · Pull Request #11145 · espressif/arduino-esp32 (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks23 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Description of Change

Fix typo in OV2640's index of the CameraWebServer example.

Created by following instructions in the issue.

Related links

Closes #10906

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 595aa1b

I wonder why the difference is 100 bytes when two characters were changed/swapped

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Click to expand the detailed deltas report [usage change in BYTES]

I wonder why the difference is 100 bytes when two characters were changed/swapped

I also don't know but maybe it is related to the GZ compression algorithm.

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

There isn't any other typos in arduino-esp32, esp32-arduino-lib-builder and esp-idf (and its components). We don't use files from anywhere else.

I had to refrain from fixing the error myself several times and submitting my own pull request, because I was afraid that the index.html file with the typo issue was in plain text somewhere, and the typo hadn't been fixed there. If another change is made to this index.html file, I fear that the typo error will be reintroduced.

There isn't any other typos in arduino-esp32, esp32-arduino-lib-builder and esp-idf (and its components). We don't use files from anywhere else.

that means, if somebody would add things to the index.html page have to extract and un-gz the data of the camera_index.h file, make the changes and gz it again?

okay, so no "master" index.html template file exists. thanks for clarification.