feat(zigbee): Add check, boolean returns, fix Analog, add optional reset on factoryReset by P-R-O-C-H-Y · Pull Request #11153 · espressif/arduino-esp32 (original) (raw)
| Warnings | |
|---|---|
| ⚠️ | Some issues found for the commit messages in this PR: the commit message "fix(zigbee): Fix memory leak, print esp_zb_zcl_status_t error, remove analogValue from analog EP": summary appears to be too long the commit message "fix(zigbee): Hope its finished now..": summary should not end with a period (full stop) the commit message "fix/zigbee): Add missing return in WindowCovering": summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): |
| Messages | |
|---|---|
| 📖 | This PR seems to be quite large (total lines of code: 1266), you might consider splitting it into smaller PRs |
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!
📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.