fix(eth): Set the ETH properties at the correct time by me-no-dev · Pull Request #11182 · espressif/arduino-esp32 (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks46 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This pull request includes several changes to the ETHClass in the libraries/Ethernet/src/ETH.cpp and libraries/Ethernet/src/ETH.h files. The changes primarily focus on adding support for configuring Ethernet settings such as full duplex mode, link speed, and auto-negotiation, as well as ensuring these settings are properly managed during the Ethernet initialization and shutdown processes.

Enhancements to Ethernet Configuration:

• Added new member variables _eth_started, _link_speed, _full_duplex, and _auto_negotiation to the ETHClass to store Ethernet configuration settings.
• Implemented new methods setFullDuplex, setLinkSpeed, and setAutoNegotiation to allow configuration of Ethernet settings before calling ETH.begin(). Each method includes validation to ensure settings are applied correctly. [1] [2] [3]
• Added private methods _setFullDuplex, _setLinkSpeed, and _setAutoNegotiation to apply the settings to the Ethernet hardware.

Initialization and Shutdown Process:

• Modified the ETHClass::begin and ETHClass::beginSPI methods to apply the Ethernet configuration settings (full duplex, link speed, and auto-negotiation) during the initialization process if auto-negotiation is disabled. [1] [2]
• Updated the ETHClass::end method to reset the _eth_started flag when shutting down the Ethernet interface.

Code Refactoring:

• Refactored the ETHClass constructor to initialize the new member variables.
• Ensured that the _eth_started flag is set to true after successful initialization and set to false during shutdown. [1] [2] [3]

Reference: #10923

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 5c70f49

Test Results

76 files 76 suites 12m 42s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 5c70f49.

♻️ This comment has been updated with latest results.

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Click to expand the detailed deltas report [usage change in BYTES]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM