feat(rmt): fixes example to run correctly within IDF 5.x by SuGlider · Pull Request #11292 · espressif/arduino-esp32 (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits2 Checks19 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Description of Change
This example crashes when running with the ESP32 because it doesn't support SOC_RMT_SUPPORT_TX_LOOP_AUTO_STOP feature. All other SoC were running the example correctly.
The timming was also incorrect becuase it was sending one RMT Symbol less.
This PR fixes the example to run with no crashes for all the SoC supported by Arduino Core 3.2.x+
It also fixes the blink timming as verified by a logic analizer.
Tests scenarios
Tested using the example with ESP32, S2, S3, C3 and C6.
Related links
Closes #11281
| Messages | |
|---|---|
| 📖 | 🎉 Good Job! All checks are passing! |
👋 Hello SuGlider, we appreciate your contribution to this project!
📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by 🚫 dangerJS against 0aa6a34
Memory usage test (comparing PR against master branch)
The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
| Memory | FLASH [bytes] | FLASH [%] | RAM [bytes] | RAM [%] | ||||
|---|---|---|---|---|---|---|---|---|
| Target | DEC | INC | DEC | INC | DEC | INC | DEC | INC |
| ESP32P4 | 💚 -10 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32S3 | 0 | ⚠️ +4 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32S2 | 💚 -4 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32C3 | 💚 -12 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32C6 | 💚 -10 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32H2 | 💚 -10 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
| ESP32 | 💚 -12 | 0 | 0.00 | 0.00 | 0 | 0 | 0.00 | 0.00 |
Click to expand the detailed deltas report [usage change in BYTES]
| Target | ESP32P4 | ESP32S3 | ESP32S2 | ESP32C3 | ESP32C6 | ESP32H2 | ESP32 | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Example | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM | FLASH | RAM |
| libraries/ESP32/examples/RMT/RMT_LED_Blink | 💚 -10 | 0 | ⚠️ +4 | 0 | 💚 -4 | 0 | 💚 -12 | 0 | 💚 -10 | 0 | 💚 -10 | 0 | 💚 -12 | 0 |
feat(rmt): fixes exaple to run correctly within IDF 5.x feat(rmt): fixes example to run correctly within IDF 5.x
