Make LwIP Core Locking available by HamzaHajeir · Pull Request #186 · espressif/esp32-arduino-lib-builder (original) (raw)

One! use case. Why should a setup be changed that may introduce side effects hitting all espressif32 Arduino users? My experience Lwip setup changes should be only done to fix a bug hitting most use cases. For special use cases there is the Arduino Lib Builder ;-)

I know that, and for that matter I've been using the builder for at least more than a year.

But per the lock feature, it has no side effects, as it's well ported to esp-idf:
https://github.com/espressif/esp-lwip/blob/a45be9e438f6cf9c54ec150581819c3b95d5af6b/src/include/lwip/tcpip.h#L52-L64
https://github.com/espressif/esp-idf/tree/master/components/lwip/port/freertos

BTW, the H4 Stack is completely Async, with complete reliable stack starting from TCP to the application (MQTT/HTTPS WebServer/WSS/HTTPS Client). I've a running MQTT that publishes 13kB payload every 3 seconds over TLS, alongwith running HTTPS WebServer/WSS/HTTP Client, with lots of other stress tests performed.

The Lock is needed to allow it for public use with the official Arduino Core for at least the plain TCP part now.