response: add support for ETag option in res.sendFile by juanarbol · Pull Request #6073 · expressjs/express (original) (raw)

Can we make a test that ensure the that the Etag option is added by deafult? This will help us to document this change and to avoid regressions in the future.

Etag is included by default. In the upper tests, you'll see that validation. See

express/test/res.sendFile.js

Line 65 ina46cfdc

Currently we don't include etag, so we should consider this as a minor or a major change?

We do, for sendFIle, this patch will make express aware that even on sendFile, it should not ignore the Etag disabled.