Update REST and wire protocol query params for `startAfter`, `endBefore` by tohhsinpei · Pull Request #6706 · firebase/firebase-js-sdk (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation32 Commits9 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We now support startAfter and endBefore on our REST endpoints (b/207844859). We've also added the fields sin ("start is inclusive") and ein ("end is inclusive") to the wire protocol payload (https://github.com/firebase/firebase-server/pull/4006).

These are the corresponding client-side updates. Note that we don't need to compute the successor or predecessor value anymore.

Note that CI checks will fail until the new NSS version is released.

Size Report 1

Affected Products

@firebase/database

Type	Base (a9add5e)	Merge (77a5149)	Diff
browser	248 kB	247 kB	-763 B (-0.3%)
esm5	276 kB	275 kB	-802 B (-0.3%)
main	281 kB	281 kB	-802 B (-0.3%)
module	248 kB	247 kB	-763 B (-0.3%)

@firebase/database-compat/standalone

Type	Base (a9add5e)	Merge (77a5149)	Diff
main	370 kB	369 kB	-802 B (-0.2%)

bundle

Type	Base (a9add5e)	Merge (77a5149)	Diff
database (Append to a list of data)	148 kB	148 kB	+103 B (+0.1%)
database (Filtering data)	147 kB	147 kB	+103 B (+0.1%)
database (Listen for child events)	163 kB	163 kB	+551 B (+0.3%)
database (Listen for value events + Detach listeners)	163 kB	163 kB	+551 B (+0.3%)
database (Listen for value events)	163 kB	163 kB	+551 B (+0.3%)
database (Read data once)	162 kB	163 kB	+551 B (+0.3%)
database (Save data as transactions)	165 kB	165 kB	+551 B (+0.3%)
database (Sort data)	148 kB	148 kB	+103 B (+0.1%)
database (Write data)	147 kB	147 kB	+103 B (+0.1%)

firebase

Type	Base (a9add5e)	Merge (77a5149)	Diff
firebase-compat.js	740 kB	740 kB	-217 B (-0.0%)
firebase-database-compat.js	166 kB	165 kB	-217 B (-0.1%)
firebase-database.js	154 kB	154 kB	-236 B (-0.2%)

Test Logs

Base (a9add5e): https://github.com/firebase/firebase-js-sdk/actions/runs/3472236134
Merge (77a5149): https://github.com/firebase/firebase-js-sdk/actions/runs/3472315447

https://storage.googleapis.com/firebase-sdk-metric-reports/r92rXRt0pQ.html

Size Analysis Report 1

Affected Products

`@firebase/database`

DataSnapshot

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

Database

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	115 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

OnDisconnect

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	119 kB	119 kB	+103 B (+0.1%)
size-with-ext-deps	141 kB	141 kB	+103 B (+0.1%)

QueryConstraint

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

TransactionResult

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_QueryImpl

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	115 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_QueryParams

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	115 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_ReferenceImpl

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_TEST_ACCESS_forceRestClient

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_TEST_ACCESS_hijackHash

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_repoManagerDatabaseFromApp

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_setSDKVersion

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	115 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_validatePathString

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

_validateWritablePath

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

child

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

connectDatabaseEmulator

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

enableLogging

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

endAt

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	118 kB	118 kB	+103 B (+0.1%)
size-with-ext-deps	139 kB	139 kB	+103 B (+0.1%)

endBefore

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	119 kB	118 kB	-418 B (-0.4%)
size-with-ext-deps	140 kB	139 kB	-419 B (-0.3%)
Dependency
Type	Base (a9add5e)	Merge (77a5149)	Diff
---------	-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------	-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------	------------------------------------------------------------------------------------
variables	149 dependenciesAPPLICATION_ID_PARAM APP_CHECK_TOKEN_PARAM BYTES_RECEIVED_HEALTHY_OVERRIDE BYTES_SENT_HEALTHY_OVERRIDE CONTROL_ERROR CONTROL_PONG CONTROL_RESET CONTROL_SHUTDOWN DELAY_BEFORE_SENDING_EXTRA_REQUESTS EMPTY_NODE END_TRANSMISSION EmptyChildren FIREBASE_DATABASE_EMULATOR_HOST_VAR FIREBASE_LONGPOLL_CALLBACK_ID_PARAM FIREBASE_LONGPOLL_CLOSE_COMMAND FIREBASE_LONGPOLL_COMMAND_CB_NAME FIREBASE_LONGPOLL_DATA_CB_NAME FIREBASE_LONGPOLL_DATA_PARAM FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM FIREBASE_LONGPOLL_ID_PARAM FIREBASE_LONGPOLL_PW_PARAM FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM FIREBASE_LONGPOLL_SERIAL_PARAM FIREBASE_LONGPOLL_START_PARAM FIRST_STATS_MAX_TIME FIRST_STATS_MIN_TIME FORGE_DOMAIN_RE FORGE_REF INTEGER_32_MAX INTEGER_32_MIN INTEGER_REGEXP_ INTERRUPT_REASON INVALID_KEY_REGEX_ INVALID_PATH_REGEX_ INVALID_TOKEN_THRESHOLD KEEPALIVE_REQUEST_INTERVAL KEY_INDEX LAST_SESSION_PARAM LOG_2 LONG_POLLING LP_CONNECT_TIMEOUT LUIDGenerator MAX_KEY_LEN MAX_LEAF_SIZE_ MAX_NAME MAX_NODE MAX_NODE$1 MAX_NODE$2 MAX_PATH_DEPTH MAX_PATH_LENGTH_BYTES MAX_PAYLOAD_SIZE MAX_PUSH_CHAR MAX_TRANSACTION_RETRIES MAX_URL_DATA_SIZE MESSAGE_DATA MESSAGE_TYPE MIN_NAME MIN_PUSH_CHAR NO_COMPLETE_CHILD_SOURCE ObjectToUniqueKey OperationType PING PRIORITY_INDEX PROTOCOL_VERSION PUSH_CHARS PersistentStorage RECONNECT_DELAY_MULTIPLIER RECONNECT_DELAY_RESET_TIMEOUT RECONNECT_MAX_DELAY_DEFAULT RECONNECT_MAX_DELAY_FOR_ADMINS RECONNECT_MIN_DELAY REFERER_PARAM REPORT_STATS_INTERVAL SDK_VERSION SEG_HEADER_SIZE SERVER_HELLO SERVER_KILL_INTERRUPT_REASON SWITCH_ACK SessionStorage TRANSPORT_SESSION_PARAM UPGRADE_TIMEOUT USE_HINZE VALUE_INDEX VERSION_PARAM WEBSOCKET WEBSOCKET_KEEPALIVE_INTERVAL WEBSOCKET_MAX_FRAME_SIZE WebSocketImpl __EMPTY_NODE __childrenNodeConstructor _defaultIndexMap beingCrawled buildChildSet buildLogMessage_ collections createStoragefor doubleToIEEE754String emptyChildrenSingleton enableLogging$1 error exceptionGuard executeWhenDOMReady fallbackObject fatal firstLog_ generateWithValues isChromeExtensionContentScript isInvalidJSONNumber isValidKey isValidPathString isValidPriority isValidRootPathString isWindowsStoreApp log logClient logWrapper logger name nameCompare nodeFromJSON$1 parseDatabaseURL parseRepoInfo predecessor priorityHashText referenceConstructor referenceConstructor$1 reporters repos requireKey resolveComplexDeferredValue resolveDeferredLeafValue resolveDeferredValueSnapshot resolveDeferredValueTree resolveScalarDeferredValue setTimeoutNonBlocking sha1 splitStringBySize stringCompare tryParseInt useRestClient validateFirebaseData validateFirebaseDataArg validateKey validatePriorityNode validateUrl version warn warnIfPageIsSecure	144 dependenciesAPPLICATION_ID_PARAM APP_CHECK_TOKEN_PARAM BYTES_RECEIVED_HEALTHY_OVERRIDE BYTES_SENT_HEALTHY_OVERRIDE CONTROL_ERROR CONTROL_PONG CONTROL_RESET CONTROL_SHUTDOWN DELAY_BEFORE_SENDING_EXTRA_REQUESTS EMPTY_NODE END_TRANSMISSION EmptyChildren FIREBASE_DATABASE_EMULATOR_HOST_VAR FIREBASE_LONGPOLL_CALLBACK_ID_PARAM FIREBASE_LONGPOLL_CLOSE_COMMAND FIREBASE_LONGPOLL_COMMAND_CB_NAME FIREBASE_LONGPOLL_DATA_CB_NAME FIREBASE_LONGPOLL_DATA_PARAM FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM FIREBASE_LONGPOLL_ID_PARAM FIREBASE_LONGPOLL_PW_PARAM FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM FIREBASE_LONGPOLL_SERIAL_PARAM FIREBASE_LONGPOLL_START_PARAM FIRST_STATS_MAX_TIME FIRST_STATS_MIN_TIME FORGE_DOMAIN_RE FORGE_REF INTEGER_32_MAX INTEGER_32_MIN INTEGER_REGEXP_ INTERRUPT_REASON INVALID_KEY_REGEX_ INVALID_PATH_REGEX_ INVALID_TOKEN_THRESHOLD KEEPALIVE_REQUEST_INTERVAL KEY_INDEX LAST_SESSION_PARAM LOG_2 LONG_POLLING LP_CONNECT_TIMEOUT LUIDGenerator MAX_LEAF_SIZE_ MAX_NAME MAX_NODE MAX_NODE$1 MAX_NODE$2 MAX_PATH_DEPTH MAX_PATH_LENGTH_BYTES MAX_PAYLOAD_SIZE MAX_TRANSACTION_RETRIES MAX_URL_DATA_SIZE MESSAGE_DATA MESSAGE_TYPE MIN_NAME NO_COMPLETE_CHILD_SOURCE ObjectToUniqueKey OperationType PING PRIORITY_INDEX PROTOCOL_VERSION PersistentStorage RECONNECT_DELAY_MULTIPLIER RECONNECT_DELAY_RESET_TIMEOUT RECONNECT_MAX_DELAY_DEFAULT RECONNECT_MAX_DELAY_FOR_ADMINS RECONNECT_MIN_DELAY REFERER_PARAM REPORT_STATS_INTERVAL SDK_VERSION SEG_HEADER_SIZE SERVER_HELLO SERVER_KILL_INTERRUPT_REASON SWITCH_ACK SessionStorage TRANSPORT_SESSION_PARAM UPGRADE_TIMEOUT USE_HINZE VALUE_INDEX VERSION_PARAM WEBSOCKET WEBSOCKET_KEEPALIVE_INTERVAL WEBSOCKET_MAX_FRAME_SIZE WebSocketImpl __EMPTY_NODE __childrenNodeConstructor _defaultIndexMap beingCrawled buildChildSet buildLogMessage_ collections createStoragefor doubleToIEEE754String emptyChildrenSingleton enableLogging$1 error exceptionGuard executeWhenDOMReady fallbackObject fatal firstLog_ generateWithValues isChromeExtensionContentScript isInvalidJSONNumber isValidKey isValidPathString isValidPriority isValidRootPathString isWindowsStoreApp log logClient logWrapper logger name nameCompare nodeFromJSON$1 parseDatabaseURL parseRepoInfo priorityHashText referenceConstructor referenceConstructor$1 reporters repos requireKey resolveComplexDeferredValue resolveDeferredLeafValue resolveDeferredValueSnapshot resolveDeferredValueTree resolveScalarDeferredValue setTimeoutNonBlocking sha1 splitStringBySize stringCompare tryParseInt useRestClient validateFirebaseData validateFirebaseDataArg validateKey validatePriorityNode validateUrl version warn warnIfPageIsSecure	- MAX_KEY_LEN - MAX_PUSH_CHAR - MIN_PUSH_CHAR - PUSH_CHARS - predecessor

equalTo

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	119 kB	119 kB	+103 B (+0.1%)
size-with-ext-deps	140 kB	140 kB	+103 B (+0.1%)

forceLongPolling

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

forceWebSockets

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

get

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	132 kB	+551 B (+0.4%)
size-with-ext-deps	153 kB	154 kB	+551 B (+0.4%)

getDatabase

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	145 kB	146 kB	+103 B (+0.1%)

goOffline

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

goOnline

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

increment

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

limitToFirst

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

limitToLast

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

off

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	124 kB	124 kB	+103 B (+0.1%)
size-with-ext-deps	145 kB	145 kB	+103 B (+0.1%)

onChildAdded

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	133 kB	+551 B (+0.4%)
size-with-ext-deps	154 kB	154 kB	+551 B (+0.4%)

onChildChanged

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	133 kB	+551 B (+0.4%)
size-with-ext-deps	154 kB	154 kB	+551 B (+0.4%)

onChildMoved

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	133 kB	+551 B (+0.4%)
size-with-ext-deps	154 kB	154 kB	+551 B (+0.4%)

onChildRemoved

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	133 kB	+551 B (+0.4%)
size-with-ext-deps	154 kB	154 kB	+551 B (+0.4%)

onDisconnect

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	119 kB	120 kB	+103 B (+0.1%)
size-with-ext-deps	141 kB	141 kB	+103 B (+0.1%)

onValue

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	132 kB	133 kB	+551 B (+0.4%)
size-with-ext-deps	154 kB	154 kB	+551 B (+0.4%)

orderByChild

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	118 kB	118 kB	+103 B (+0.1%)
size-with-ext-deps	139 kB	139 kB	+103 B (+0.1%)

orderByKey

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

orderByPriority

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

orderByValue

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

push

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	118 kB	118 kB	+103 B (+0.1%)
size-with-ext-deps	139 kB	139 kB	+103 B (+0.1%)

query

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

ref

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

refFromURL

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

remove

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

runTransaction

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	134 kB	135 kB	+551 B (+0.4%)
size-with-ext-deps	156 kB	156 kB	+551 B (+0.4%)

serverTimestamp

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	115 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	137 kB	137 kB	+103 B (+0.1%)

set

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	116 kB	116 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

setPriority

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

setWithPriority

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	117 kB	117 kB	+103 B (+0.1%)
size-with-ext-deps	138 kB	138 kB	+103 B (+0.1%)

startAfter

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	119 kB	118 kB	-430 B (-0.4%)
size-with-ext-deps	140 kB	139 kB	-430 B (-0.3%)
Dependency
Type	Base (a9add5e)	Merge (77a5149)	Diff
---------	---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------	-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------	----------------------------------------------------------------------------------
variables	149 dependenciesAPPLICATION_ID_PARAM APP_CHECK_TOKEN_PARAM BYTES_RECEIVED_HEALTHY_OVERRIDE BYTES_SENT_HEALTHY_OVERRIDE CONTROL_ERROR CONTROL_PONG CONTROL_RESET CONTROL_SHUTDOWN DELAY_BEFORE_SENDING_EXTRA_REQUESTS EMPTY_NODE END_TRANSMISSION EmptyChildren FIREBASE_DATABASE_EMULATOR_HOST_VAR FIREBASE_LONGPOLL_CALLBACK_ID_PARAM FIREBASE_LONGPOLL_CLOSE_COMMAND FIREBASE_LONGPOLL_COMMAND_CB_NAME FIREBASE_LONGPOLL_DATA_CB_NAME FIREBASE_LONGPOLL_DATA_PARAM FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM FIREBASE_LONGPOLL_ID_PARAM FIREBASE_LONGPOLL_PW_PARAM FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM FIREBASE_LONGPOLL_SERIAL_PARAM FIREBASE_LONGPOLL_START_PARAM FIRST_STATS_MAX_TIME FIRST_STATS_MIN_TIME FORGE_DOMAIN_RE FORGE_REF INTEGER_32_MAX INTEGER_32_MIN INTEGER_REGEXP_ INTERRUPT_REASON INVALID_KEY_REGEX_ INVALID_PATH_REGEX_ INVALID_TOKEN_THRESHOLD KEEPALIVE_REQUEST_INTERVAL KEY_INDEX LAST_SESSION_PARAM LOG_2 LONG_POLLING LP_CONNECT_TIMEOUT LUIDGenerator MAX_KEY_LEN MAX_LEAF_SIZE_ MAX_NAME MAX_NODE MAX_NODE$1 MAX_NODE$2 MAX_PATH_DEPTH MAX_PATH_LENGTH_BYTES MAX_PAYLOAD_SIZE MAX_PUSH_CHAR MAX_TRANSACTION_RETRIES MAX_URL_DATA_SIZE MESSAGE_DATA MESSAGE_TYPE MIN_NAME MIN_PUSH_CHAR NO_COMPLETE_CHILD_SOURCE ObjectToUniqueKey OperationType PING PRIORITY_INDEX PROTOCOL_VERSION PUSH_CHARS PersistentStorage RECONNECT_DELAY_MULTIPLIER RECONNECT_DELAY_RESET_TIMEOUT RECONNECT_MAX_DELAY_DEFAULT RECONNECT_MAX_DELAY_FOR_ADMINS RECONNECT_MIN_DELAY REFERER_PARAM REPORT_STATS_INTERVAL SDK_VERSION SEG_HEADER_SIZE SERVER_HELLO SERVER_KILL_INTERRUPT_REASON SWITCH_ACK SessionStorage TRANSPORT_SESSION_PARAM UPGRADE_TIMEOUT USE_HINZE VALUE_INDEX VERSION_PARAM WEBSOCKET WEBSOCKET_KEEPALIVE_INTERVAL WEBSOCKET_MAX_FRAME_SIZE WebSocketImpl __EMPTY_NODE __childrenNodeConstructor _defaultIndexMap beingCrawled buildChildSet buildLogMessage_ collections createStoragefor doubleToIEEE754String emptyChildrenSingleton enableLogging$1 error exceptionGuard executeWhenDOMReady fallbackObject fatal firstLog_ generateWithValues isChromeExtensionContentScript isInvalidJSONNumber isValidKey isValidPathString isValidPriority isValidRootPathString isWindowsStoreApp log logClient logWrapper logger name nameCompare nodeFromJSON$1 parseDatabaseURL parseRepoInfo priorityHashText referenceConstructor referenceConstructor$1 reporters repos requireKey resolveComplexDeferredValue resolveDeferredLeafValue resolveDeferredValueSnapshot resolveDeferredValueTree resolveScalarDeferredValue setTimeoutNonBlocking sha1 splitStringBySize stringCompare successor tryParseInt useRestClient validateFirebaseData validateFirebaseDataArg validateKey validatePriorityNode validateUrl version warn warnIfPageIsSecure	144 dependenciesAPPLICATION_ID_PARAM APP_CHECK_TOKEN_PARAM BYTES_RECEIVED_HEALTHY_OVERRIDE BYTES_SENT_HEALTHY_OVERRIDE CONTROL_ERROR CONTROL_PONG CONTROL_RESET CONTROL_SHUTDOWN DELAY_BEFORE_SENDING_EXTRA_REQUESTS EMPTY_NODE END_TRANSMISSION EmptyChildren FIREBASE_DATABASE_EMULATOR_HOST_VAR FIREBASE_LONGPOLL_CALLBACK_ID_PARAM FIREBASE_LONGPOLL_CLOSE_COMMAND FIREBASE_LONGPOLL_COMMAND_CB_NAME FIREBASE_LONGPOLL_DATA_CB_NAME FIREBASE_LONGPOLL_DATA_PARAM FIREBASE_LONGPOLL_DISCONN_FRAME_REQUEST_PARAM FIREBASE_LONGPOLL_ID_PARAM FIREBASE_LONGPOLL_PW_PARAM FIREBASE_LONGPOLL_SEGMENTS_IN_PACKET FIREBASE_LONGPOLL_SEGMENT_NUM_PARAM FIREBASE_LONGPOLL_SERIAL_PARAM FIREBASE_LONGPOLL_START_PARAM FIRST_STATS_MAX_TIME FIRST_STATS_MIN_TIME FORGE_DOMAIN_RE FORGE_REF INTEGER_32_MAX INTEGER_32_MIN INTEGER_REGEXP_ INTERRUPT_REASON INVALID_KEY_REGEX_ INVALID_PATH_REGEX_ INVALID_TOKEN_THRESHOLD KEEPALIVE_REQUEST_INTERVAL KEY_INDEX LAST_SESSION_PARAM LOG_2 LONG_POLLING LP_CONNECT_TIMEOUT LUIDGenerator MAX_LEAF_SIZE_ MAX_NAME MAX_NODE MAX_NODE$1 MAX_NODE$2 MAX_PATH_DEPTH MAX_PATH_LENGTH_BYTES MAX_PAYLOAD_SIZE MAX_TRANSACTION_RETRIES MAX_URL_DATA_SIZE MESSAGE_DATA MESSAGE_TYPE MIN_NAME NO_COMPLETE_CHILD_SOURCE ObjectToUniqueKey OperationType PING PRIORITY_INDEX PROTOCOL_VERSION PersistentStorage RECONNECT_DELAY_MULTIPLIER RECONNECT_DELAY_RESET_TIMEOUT RECONNECT_MAX_DELAY_DEFAULT RECONNECT_MAX_DELAY_FOR_ADMINS RECONNECT_MIN_DELAY REFERER_PARAM REPORT_STATS_INTERVAL SDK_VERSION SEG_HEADER_SIZE SERVER_HELLO SERVER_KILL_INTERRUPT_REASON SWITCH_ACK SessionStorage TRANSPORT_SESSION_PARAM UPGRADE_TIMEOUT USE_HINZE VALUE_INDEX VERSION_PARAM WEBSOCKET WEBSOCKET_KEEPALIVE_INTERVAL WEBSOCKET_MAX_FRAME_SIZE WebSocketImpl __EMPTY_NODE __childrenNodeConstructor _defaultIndexMap beingCrawled buildChildSet buildLogMessage_ collections createStoragefor doubleToIEEE754String emptyChildrenSingleton enableLogging$1 error exceptionGuard executeWhenDOMReady fallbackObject fatal firstLog_ generateWithValues isChromeExtensionContentScript isInvalidJSONNumber isValidKey isValidPathString isValidPriority isValidRootPathString isWindowsStoreApp log logClient logWrapper logger name nameCompare nodeFromJSON$1 parseDatabaseURL parseRepoInfo priorityHashText referenceConstructor referenceConstructor$1 reporters repos requireKey resolveComplexDeferredValue resolveDeferredLeafValue resolveDeferredValueSnapshot resolveDeferredValueTree resolveScalarDeferredValue setTimeoutNonBlocking sha1 splitStringBySize stringCompare tryParseInt useRestClient validateFirebaseData validateFirebaseDataArg validateKey validatePriorityNode validateUrl version warn warnIfPageIsSecure	- MAX_KEY_LEN - MAX_PUSH_CHAR - MIN_PUSH_CHAR - PUSH_CHARS - successor

startAt

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	118 kB	118 kB	+103 B (+0.1%)
size-with-ext-deps	139 kB	139 kB	+103 B (+0.1%)

update

Size

Type	Base (a9add5e)	Merge (77a5149)	Diff
size	118 kB	118 kB	+103 B (+0.1%)
size-with-ext-deps	139 kB	139 kB	+103 B (+0.1%)

Test Logs

Base (a9add5e): https://github.com/firebase/firebase-js-sdk/actions/runs/3472236134
Merge (77a5149): https://github.com/firebase/firebase-js-sdk/actions/runs/3472315447

https://storage.googleapis.com/firebase-sdk-metric-reports/vKoG90beeP.html

tohhsinpei changed the title~~Update REST and wire protocol query constants for startAfter, endBefore~~ Update REST and wire protocol query params for startAfter, endBefore

Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great cleanup!

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

tohhsinpei changed the base branch from master to mtewani/fix-syncpoint-test-compare

November 14, 2022 19:40

Base automatically changed from mtewani/fix-syncpoint-test-compare to master

November 15, 2022 16:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

firebase locked and limited conversation to collaborators

Dec 19, 2022

Reviewers

maneesht maneesht approved these changes

hsubox76 hsubox76 approved these changes

jsdt Awaiting requested review from jsdt

dwyfrequency Awaiting requested review from dwyfrequency

egilmorez Awaiting requested review from egilmorez

jmwski Awaiting requested review from jmwski

markarndt Awaiting requested review from markarndt

Update REST and wire protocol query params for startAfter, endBefore by tohhsinpei · Pull Request #6706 · firebase/firebase-js-sdk (original) (raw)

Conversation

Size Report 1

Affected Products

@firebase/database

@firebase/database-compat/standalone

bundle

firebase

Test Logs

Size Analysis Report 1

Affected Products

@firebase/database

DataSnapshot

Database

OnDisconnect

QueryConstraint

TransactionResult

_QueryImpl

_QueryParams

_ReferenceImpl

_TEST_ACCESS_forceRestClient

_TEST_ACCESS_hijackHash

_repoManagerDatabaseFromApp

_setSDKVersion

_validatePathString

_validateWritablePath

child

connectDatabaseEmulator

enableLogging

endAt

endBefore

equalTo

forceLongPolling

forceWebSockets

get

getDatabase

goOffline

goOnline

increment

limitToFirst

limitToLast

off

onChildAdded

onChildChanged

onChildMoved

onChildRemoved

onDisconnect

onValue

orderByChild

orderByKey

orderByPriority

orderByValue

push

query

ref

refFromURL

remove

runTransaction

serverTimestamp

set

setPriority

setWithPriority

startAfter

startAt

update

Test Logs

Choose a reason for hiding this comment

Changeset File Check ✅

Choose a reason for hiding this comment

Reviewers

Update REST and wire protocol query params for `startAfter`, `endBefore` by tohhsinpei · Pull Request #6706 · firebase/firebase-js-sdk (original) (raw)

`@firebase/database`

`@firebase/database-compat/standalone`

`bundle`

`firebase`

`@firebase/database`

`DataSnapshot`

`Database`

`OnDisconnect`

`QueryConstraint`

`TransactionResult`

`_QueryImpl`

`_QueryParams`

`_ReferenceImpl`

`_TEST_ACCESS_forceRestClient`

`_TEST_ACCESS_hijackHash`

`_repoManagerDatabaseFromApp`

`_setSDKVersion`

`_validatePathString`

`_validateWritablePath`

`child`

`connectDatabaseEmulator`

`enableLogging`

`endAt`

`endBefore`

`equalTo`

`forceLongPolling`

`forceWebSockets`

`get`

`getDatabase`

`goOffline`

`goOnline`

`increment`

`limitToFirst`

`limitToLast`

`off`

`onChildAdded`

`onChildChanged`

`onChildMoved`

`onChildRemoved`

`onDisconnect`

`onValue`

`orderByChild`

`orderByKey`

`orderByPriority`

`orderByValue`

`push`

`query`

`ref`

`refFromURL`

`remove`

`runTransaction`

`serverTimestamp`

`set`

`setPriority`

`setWithPriority`

`startAfter`

`startAt`

`update`