fix(forge): remove strategy section from workflow template to simplify by winor30 · Pull Request #10434 · foundry-rs/foundry (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation1 Commits1 Checks22 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Motivation
According to the JSON Schema for GitHub Actions workflows (maintained by SchemaStore), the matrix field is required when using the strategy section. However, this template typically doesn't need this level of complexity that matrix configurations provide.
Solution
This PR removes the strategy section from the workflow template.
- Refactor the Foundry project workflow for improved clarity and efficiency.
- Remove the
fail-fastoption to ensure all checks run regardless of failures. - Streamline job configurations for better maintainability and readability.
Signed-off-by: katsumata 12413150+winor30@users.noreply.github.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
Reviewers
2 participants
