Allow scans with packs for languages not being scanned by aeisenberg · Pull Request #1116 · github/codeql-action (original) (raw)
Conversation
Previously, we were being too strict about checking that a pack's
language was being scanned. It was a failure if a pack language
was specified for a language not being scanned.
Merge / deployment checklist
- Confirm this change is backwards compatible with existing workflows.
- Confirm the readme has been updated if necessary.
- Confirm the changelog has been updated if necessary.
| if (!languages.includes(lang as Language)) { |
|---|
| throw new Error(getPacksRequireLanguage(lang, configFile)); |
| // This particular language is not being analyzed in this run. |
| continue; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that we won't fail on the pack with the wrong language, but we won't attempt to run the pack below either, right? A comment to that effect would be great.
Currently failing on the nightly builds. These should be fixed by github/codeql#9667. I am currently building a nightly release that should contain the fix.
Previously, we were being too strict about checking that a pack's language was being scanned. It was a failure if a pack language was specified for a language not being scanned.
@adityasharad can I get another look at this PR from you? I'd like to get this in the next release.
Co-authored-by: Aditya Sharad 6874315+adityasharad@users.noreply.github.com
This was referenced
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
