Remove MismatchedBranches check from code scanning workflow validation by shaikhul · Pull Request #1675 · github/codeql-action (original) (raw)
Conversation
Remove MismatchedBranches check from code scanning workflow validation as these two have misleading wording.
Merge / deployment checklist
- Confirm this change is backwards compatible with existing workflows.
- Confirm the readme has been updated if necessary.
- Confirm the changelog has been updated if necessary.
My understanding is that the main change of this PR is to remove the checks for push triggers in code scanning workflows, since with the simplified diff approach this is no longer required. If that's right, could we update the PR title / description accordingly? We may also want to add a brief changelog note in CHANGELOG.md. This will make it easier to find this PR in the future.
Remove consts MismatchedBranches and MissingPushHook Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation
Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation Remove MismatchedBranches check from code scanning workflow validation
Co-authored-by: Henry Mercer henry.mercer@me.com
@shaikhul Would you mind recompiling the Action and pushing again? 🙏 Unfortunately for now we need to check in the compiled code.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! One fix to the changelog format I didn't notice before, otherwise this is good to go!
Co-authored-by: Henry Mercer henry.mercer@me.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
2 participants
