Add support for the code_scanning_codeql_java_lombok feature flag by igfoo · Pull Request #1809 · github/codeql-action (original) (raw)
Conversation
I think the minimumVersion could be older, but I don't think it's worth the time to work out exactly how old.
Merge / deployment checklist
- Confirm this change is backwards compatible with existing workflows.
- Confirm the readme has been updated if necessary.
- Confirm the changelog has been updated if necessary.
| { envVar: string; minimumVersion: string | undefined; defaultValue: boolean } |
|---|
| > = { |
| [Feature.CodeqlJavaLombokEnabled]: { |
| envVar: "CODEQL_JAVA_LOMBOK_ENABLED", |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the others environment variable overrides for the feature flag!
| envVar: "CODEQL_JAVA_LOMBOK_ENABLED", |
|---|
| envVar: "CODEQL_JAVA_LOMBOK", |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should do it 😸
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})