Ensure --overwrite flag is only passed once by henrymercer · Pull Request #2245 · github/codeql-action (original) (raw)

This fixes a bug where if CODEQL_ACTION_EXTRA_OPTIONS specified that --overwrite should be passed to database init, the --overwrite argument would be passed twice, leading to an error.

To accomplish this, I introduce an ignoringOptions argument to specify options in CODEQL_ACTION_EXTRA_OPTIONS that should be ignored. It would be nice to have a general solution that didn't require specifying which options should be ignored, but the problem with that is that it does make sense to pass some flags more than once.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Confirm the readme has been updated if necessary.
• Confirm the changelog has been updated if necessary.