Not able to apply the patches from #1521 PR · gitpython-developers/GitPython · Discussion #1529 (original) (raw)

You should be good ignoring the changes to tests, make also sure to apply the changes from #1518.

You must be logged in to vote

7 replies

@nrpt-m

@stsewd Could you please check these patches & confirm if these patches will be able to fix the CVE-2022-24439 ?

@stsewd

Hi there, I've been busy, took a quick look and patches look okay.

@nrpt-m

@philsuth

@nrpt-m - In line 294 of your PR1521 patch I think there's an indentation error (breaking line 700 of remote.py): the "url = Git.polish_url(url)" is indented one space too far. Noticed this over in yocto/poky where the patches have been recently merged into Kirkstone. Will you follow up there or should I?

@nrpt-m

@philsuth, Thanks for your sharp observations. It would be great help if you could follow up there.

Answer selected by nrpt-m