Remove @NoEffect annotations by EliahKagan · Pull Request #1677 · gitpython-developers/GitPython (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully clear on what is expected to happen. In context, we have:
| # some commits earlier we still have a submodule, but its at a different commit |
|---|
| smold = next(Submodule.iter_items(rwrepo, self.k_subm_changed)) |
| assert smold.binsha != sm.binsha |
| assert smold != sm # the name changed |
| # force it to reread its information |
| del smold._url |
| smold.url == sm.url # noqa: B015 # FIXME: Should this be an assertion? |
When it is made into an assertion, pytest shows:
E AssertionError: assert 'git://gitorious.org/git-python/gitdb.git' == 'https://github.com/gitpython-developers/gitdb.git'
E - https://github.com/gitpython-developers/gitdb.git
E + git://gitorious.org/git-python/gitdb.git
test/test_submodule.py:114: AssertionError
Is the different remote URL part of what this intends to test? Or is this something that broke at some point (or would have broken, if it were an assertion) as a result of moving the remote to GitHub?