Split tox lint env into three envs, all safe by EliahKagan · Pull Request #1870 · gitpython-developers/GitPython (original) (raw)

See 4c034db for details on the main changes.

This adds tox environments for both linting and format checking with Ruff, specifying Ruff as a dependency and calling it in such a way that it does not mutate files in the working tree, since one expects tox not to do that. This still has tox use pre-commit to run other hooks (which do not modify files).

Since none of these modify files, they all can and should run automatically when tox is run with no arguments, so they are added to the env_list (which the old lint env had been removed from in #1868, pending a change like this).

With this approach taken, there is no clear use for the already-unused manual hook stage in the near future anymore, and it's easy to bring back if needed, so I've also removed that, including in the CI linting workflow.

After adding the tox envs for Ruff, I tweaked them so they would show colored output, so then I went ahead and made a similar change for mypy when run with tox. I have included that here as well, even though it is not related to Ruff. But the changes here do not cause mypy to show colored output when run in the pythonpackage.yml workflow, because I ended up doing that in #1859 to help with the work there (alongside other mypy configuration improvements).