Add GitPython's Standard License Header Comments to Shell Scripts by DaveLak · Pull Request #1907 · gitpython-developers/GitPython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits2 Checks26 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

DaveLak

@DaveLak

These files are already BSD-3-Clause even without the headers, but adding these comments and the LICENSE-BSD symlink to the root level LICENSE file are helpful to reinforce that there are only two particular files in the fuzzing/ that are not under BSD-3-Clause.

See: gitpython-developers#1901 (comment)

@DaveLak

While discussing adding similar license comments to the shell scripts introduced in PR gitpython-developers#1901, it was noticed that the shell scripts in the repository root directory did not have such comments and suggested that we could add them when the scripts in the fuzzing/ directory were updated, so this commit does just that.

See: gitpython-developers#1901 (comment)

EliahKagan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Byron

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DaveLak DaveLak deleted the add-license-header-comments-to-shell-scripts branch

April 29, 2024 00:34