Derive From Variant To Variant by astrale-sharp · Pull Request #246 · godot-rust/gdext (original) (raw)

Thanks a lot for this! 👍

This only seems to implement ToVariant. Given the PR title, do you plan to also add FromVariant (could also be separate)?

Please avoid prelude for internal implementation and use the original modules, e.g. godot::builtin.

The Godot representation of tuple-structs/enums with only 1 element can be discussed. While a bit inconsistent with multiple elements, those are often specifically used for "newtypes", as such it can make sense to avoid the array. It means of course it's not easy to version them, but maybe we should recommend using named structs/enums if that is a concern.

CI is currently failing, would be nice if you could address those 🙂