Address sanitizers for Rust by Bromeon · Pull Request #325 · godot-rust/gdext (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
We have missed a lot of UB that occurred only in Rust code and wasn't detected by AddressSanitizer outside of C++ code. This PR enables ASan for Rust code using -Zsanitizer=address
in the two memcheck CI jobs. As such, this is a follow-up to #133.
The CI currently fails because there is still some UB on master
... ideally we can fix this soon.
bors try
bors bot added a commit that referenced this pull request
bors bot added a commit that referenced this pull request
try
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here.
For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here.
For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
bors bot deleted the feature/ci-asan branch
2 participants