Releases · google/error-prone (original) (raw)

Error Prone 2.50.0

New checks:

BoxingComparator: Detect implicitly-boxing Comparator.comparing key extractors
ExposedPrivateType: Discourage references to private member classes from non-private APIs
JUnitMethodInvoked: Discourage directly invoking JUnit test methods
ListRemoveAmbiguous: Detect ambiguous calls to List.remove(int|Integer)
PreferTestParameter: suggests using @TestParameter instead of @TestParameters for exhaustive boolean and enum parameters on single-element parameterized tests
RecordComponentAccessorAnnotationConflict: Detect conflicts between record components and explicit accessor methods
RecordComponentOverride: Discourage @Override on record component declarations that don't override
anything
ThrowableEqualsHashCode: Discourage overriding Throwable.equals() and hashCode()

Closed issues: #5553, #5649, #5778

This release includes several changes to Matcher APIs, and removed some deprecated or problematic APIs:

Remove deprecated MethodMatchers.withSignature API, which relies on fragile toString behaviour. Alternatives for matching on method signatures with varargs and type parameters were added in a98a1c5.
Removed variableType(Matcher) API. Matchers.variableType(Matcher) uses VariableTree#getType to match variable types, which own't work for lambda parameters with inferred types after JDK-8268850. The recommended replacement is variableType(TypePredicate).
Make enclosingPackage return an optional. Module elements are not enclosed by a package, checks using enclosingPackage shouldn't assume an enclosing package exists when processing arbitrary elements.
New FieldMatchers API, similar to MethodMatchers (1dd9c3a).

New checks:

AssertThrowsBlockToExpression: Discourage unnecessary block lambdas in assertThrows.
AssertThrowsMinimizer: Suggest minimizing the amount of logic in assertThrows.
MemorySegmentReferenceEquality: Discourage using reference equality for MemorySegments.
PreferThrowsTag: Recommends using @throws instead of the legacy @exception javadoc tag.
RecordAccessorInCompactConstructor: detect record accessors inside the compact canonical ctors, which read uninitialized fields.

Changes:

The javac flag -XDaddTypeAnnotationsToSymbol=true is now required for Error Prone invocations on JDK 21, to enable the javac fix for JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries. See #5426 for details.
Remove deprecated value attribute from @IncompatibleModifiers and @RequiredModifiers (#2122)
Error Prone API changes to encapsulate references to internal javac APIs for end position handling (EndPosTable, DiagnosticPosition) (5440bb4, 06c2905, f3915ec)

New checks:

DuplicateAssertion: detect duplicated assertion lines where the argument to assertThat is pure
IfChainToSwitch: suggest converting chains of if-statements into arrow switches
ScannerUseDelimiter: discourage Scanner.useDelimiter("\\A")
AddNullMarkedToClass: refactoring to add @NullMarked annotation to top level classes

Changes:

New checks:

AssertSameIncompatible: Detect calls to assertSame and similar assertions, where the calls are guaranteed to either succeed or fail.
FormatStringShouldUsePlaceholders: Suggests using a format string instead of string concatenation operations on format methods

Closed issues: #5335

The minimum supported JDK version to run Error Prone is now JDK 21 (#4867).

Changes:

-XepPatchChecks now skips disabled checks (#4943)
AndroidJdkLibsChecker has been removed, the recommended replacement for Android code is Android Lint's NewApi check

New checks:

NullNeedsCastForVarargs: Detect calls that incorrectly passes a null array instead of a null element.
RedundantNullCheck: detect checks on expressions that are non-null.

New checks:

ExplicitArrayForVarargs: discourage unnecessary explicit construction of an array to provide varargs.
FloggerPerWithoutRateLimit: discourage Flogger's perUnique without rate limiting
StringJoin: Ban String.join(CharSequence) and String.join(CharSequence, CharSequence)
ThreadBuilderNameWithPlaceholder: Do not allow placeholders in Thread.Builder.name(String) or name(String, int).

Changes:

The return type of ASTHelpers.asFlagSet has changed. The previous type was EnumSet<Flags.Flag>, where Flags.Flag is an enum in the javac class Flags. A recent JDK change has replaced that enum with a new top-level enum called FlagsEnum. It is not possible to change ASTHelpers.asFlagSet in a way that would be type-safe and compatible with the enums from JDKs both before and after the change. Instead, the method now returns ImmutableSet<String>, where the strings come from the toString() of the enum constants. That means they are "native", "abstract", etc.
Flag IO.print[ln]() in SystemOut.

New checks:

EffectivelyPrivate: Detect declarations that have public or protected modifiers, but are effectively private

Changes: