BUGFIX: Fail with error when read exceeds maximum by inteon · Pull Request #2328 · google/go-containerregistry (original) (raw)
Navigation Menu
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Conversation
io.ReadAll(io.LimitReader(...)) prevents OOM issues but does silently truncate long bodies. Instead, we should throw an error when a body exceeds the read limit
Signed-off-by: Tim Ramlot 42113979+inteon@users.noreply.github.com
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.94%. Comparing base (31df54c) to head (a17f0a6).
Additional details and impacted files
@@ Coverage Diff @@ ## main #2328 +/- ##
Coverage 56.91% 56.94% +0.02%
Files 165 166 +1
Lines 11362 11369 +7- Hits 6467 6474 +7
Misses 4134 4134
Partials 761 761
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})