Make requestInjection with an explicit type actually use the type by jedediah · Pull Request #1071 · google/guice (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Closed
wants to merge 1 commit into
google:masterfrom
jedediah:request-injection-with-explicit-type
ConversationCommits (1)ChecksFiles changed
Closed
Make requestInjection with an explicit type actually use the type#1071
wants to merge 1 commit into
google:masterfrom
jedediah:request-injection-with-explicit-type
Conversation
jedediah commented
Copy link Copy Markdown
Contributor
Make Binder#requestInjection(TypeLiteral, Object) scan the given TypeLiteral for dependencies, instead of always scanning the instance. This is important if the type is generic, and has generic dependencies.
TheMolkaPL and tavianator reacted with thumbs up emoji
[Make requestInjection with an explicit type actually use the type](/google/guice/pull/1071/commits/7f776dfd64e69bf2b285f0fef74841810734cf3a "Make requestInjection with an explicit type actually use the type")
[7f776df](/google/guice/pull/1071/commits/7f776dfd64e69bf2b285f0fef74841810734cf3a)
googlebot added the cla: yes label
copybara-service Bot mentioned this pull request
Make requestInjection with an explicit type actually use the type. Fixes #1071.#1703
Closed
copybara-service Bot pushed a commit that referenced this pull request
`[Make requestInjection with an explicit type actually use the type. Fixes](/google/guice/commit/6e6da795d06719eed157d053b82817020aee8d76 "Make requestInjection with an explicit type actually use the type. Fixes #1071.
PiperOrigin-RevId: 525789577") `
[6e6da79](/google/guice/commit/6e6da795d06719eed157d053b82817020aee8d76)
PiperOrigin-RevId: 525789577
copybara-service Bot closed this in
[becce74](/google/guice/commit/becce74bd99370a18bcbe10aaba6b48d227588da)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.