Make requestInjection with an explicit type actually use the type by jedediah · Pull Request #1071 · google/guice (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

google / guice Public

Additional navigation options

Closed

jedediah

wants to merge 1 commit into

google:masterfrom

jedediah:request-injection-with-explicit-type

ConversationCommits (1)ChecksFiles changed

Closed

Make requestInjection with an explicit type actually use the type#1071

jedediah

wants to merge 1 commit into

google:masterfrom

jedediah:request-injection-with-explicit-type

Conversation

@jedediah

@jedediah jedediah commented

Jan 15, 2017

Copy link Copy Markdown

Contributor

Make Binder#requestInjection(TypeLiteral, Object) scan the given TypeLiteral for dependencies, instead of always scanning the instance. This is important if the type is generic, and has generic dependencies.

TheMolkaPL and tavianator reacted with thumbs up emoji

@jedediah

[Make requestInjection with an explicit type actually use the type](/google/guice/pull/1071/commits/7f776dfd64e69bf2b285f0fef74841810734cf3a "Make requestInjection with an explicit type actually use the type")

[7f776df](/google/guice/pull/1071/commits/7f776dfd64e69bf2b285f0fef74841810734cf3a)

@googlebot googlebot added the cla: yes label

Jan 15, 2017

@copybara-service copybara-service Bot mentioned this pull request

Apr 21, 2023

Make requestInjection with an explicit type actually use the type. Fixes #1071.#1703

Closed

copybara-service Bot pushed a commit that referenced this pull request

Apr 21, 2023

@sameb

`[Make requestInjection with an explicit type actually use the type. Fixes](/google/guice/commit/6e6da795d06719eed157d053b82817020aee8d76 "Make requestInjection with an explicit type actually use the type. Fixes #1071.

PiperOrigin-RevId: 525789577") `

[6e6da79](/google/guice/commit/6e6da795d06719eed157d053b82817020aee8d76)

#1071.

PiperOrigin-RevId: 525789577

@copybara-service copybara-service Bot closed this in[becce74](/google/guice/commit/becce74bd99370a18bcbe10aaba6b48d227588da)

Apr 21, 2023

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jedediah @googlebot