fix(bqjdbc): fix Long to java.sql.Time coercion by Neenu1995 · Pull Request #13035 · googleapis/google-cloud-java (original) (raw)

Code Review

This pull request updates several JDBC methods in BigQueryBaseResultSet, BigQueryCallableStatement, and BigQueryPreparedStatement with @deprecated and @SuppressWarnings annotations to align with the JDBC specification. Additionally, it replaces a deprecated java.sql.Time constructor in BigQueryTypeCoercionUtility with a Calendar-based implementation. A review comment suggests using java.time.LocalTime and java.sql.Time.valueOf() instead of Calendar to avoid performance overhead during result set iteration, as Calendar is relatively expensive for high-frequency operations.