fix(bqjdbc): optimize meetsReadRatio latency to achieve faster page counting by Neenu1995 · Pull Request #13090 · googleapis/google-cloud-java (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BigQuery JDBC driver by deprecating several legacy methods, optimizing the High Throughput API activation logic, and refining time/timestamp coercion. Key changes include replacing an O(N) iteration for page size calculation with an O(1) approximation in BigQueryStatement, increasing the default minimum table size for High Throughput API usage, and adjusting java.sql.Time and java.sql.Timestamp conversions to ensure consistent timezone handling and precision. Review feedback highlights potential overflow and division-by-zero issues in the new page size approximation logic, as well as an inconsistency in timezone offset adjustments between different time coercion paths.