fix(bqjdbc): validate integer connection properties by Neenu1995 · Pull Request #13174 · googleapis/google-cloud-java (original) (raw)

Code Review

This pull request implements validation for JDBC connection properties to ensure they are non-negative integers. Changes include the addition of validation utility methods in BigQueryJdbcUrlUtility, their integration into URL parsing and DataSource setters, and corresponding unit tests. Review feedback identifies potential NullPointerExceptions when handling null property names or unrecognized keys and suggests using safer string comparison patterns. Additionally, the reviewer recommends expanding test coverage to include non-numeric values and unknown properties.