fix: annotating some fields as REQUIRED by gcf-owl-bot[bot] · Pull Request #1695 · googleapis/java-spanner (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
[![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4)
Is this a breaking change? If so, it would require us to do a major release, which is not ideal
@ansh0l could you follow up?
Merge the pull request once unit tests and other checks pass.
label
suztomo previously approved these changes Feb 17, 2022
@ansh0l cl/429093810 has description about the change and it says the author doesn't expect breaking change in customers' code. If this is the case, there's no need to bump the major version.
The automation bot reads "!" in "feat!" for breaking changes. If this is not a breaking change, then remove "!" from the PR title. When merging, ensure the squashed commit to the main branch doesn't have "!" either.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will go with suggestion by @suztomo for minor revision bump
Will be parking this PR for some more time before other major PRs are shipped for java and jdbc.
fix!: annotating some fields as REQUIRED fix: annotating some fields as REQUIRED
@ansh0l afaik we can merge now, because we removed the !, so it won't be a breaking change. Or do we need to wait for anything else?
@thiagotnunes I think we are good. I was busy with Spangres merges yesterday, so kept it waiting for another day.
Indicates a pull request not ready for merge, due to either quality or timing.
label
gcf-owl-bot bot added a commit that referenced this pull request
- chore(java): update gcp-releasetool and cryptography in java requirements file Source-Link: googleapis/synthtool@74d0956 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request