fix: remove the statement of session number limits by rbrtwng · Pull Request #1928 · googleapis/java-spanner (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits6 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Cloud Spanner no longer has the 10K "Sessions per database per node" limit.

Doc fix only

Fixes #1927

Cloud Spanner no longer has the 10K "Sessions per database per node" limit.

rbrtwng changed the title~~Remove the statement of session number limits~~ fix: Remove the statement of session number limits

Jun 24, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

rahul2393 changed the title~~fix: Remove the statement of session number limits~~ fix: remove the statement of session number limits

Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(will wait for presubmits to run, since this is a doc string fix, adding automerge label)

@rbrtwng : It looks like a couple of (required) presubmits fail because of minor nits.

Linting line 34 seems to have an additional whitespace at end
Conventional commits: since commit message and PR subject have different title.

Please add them and tag me, I will run the presubmits again after them.

@ansh0l can you please run presubmit again?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to make a minor change to satisfy the lint presubmit.

* It is a good idea to delete idle and/or unneeded sessions. Aside from explicit deletes,
* Cloud Spanner can delete sessions for which no operations are sent for more than an hour,
* or due to internal errors. If a session is deleted, requests to it return
* {@link ErrorCode#NOT_FOUND}.