deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.12.0.with temp exclusions. by zhumin8 · Pull Request #2512 · googleapis/java-spanner (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

…cies to v3.12.0.with temp exclusions.

ci/windows error

D:\a\java-spanner\java-spanner>"C:\Program Files\Git\bin\bash.exe" D:\a\java-spanner\java-spanner\.kokoro\build.sh 
/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.7/bin/mvn: line 92: cd: C:\Program Files\Eclipse Adoptium\jdk-11.0.18.10-hotspot\: No such file or directory
The JAVA_HOME environment variable is not defined correctly,
this environment variable is needed to run this program.

This looks to be failing for a while, not this pr specific.

@@ -82,6 +90,14 @@
com.google.api.grpc
proto-google-cloud-spanner-executor-v1
1.4.0
<!-- Temp exclusion. Remove next protobuf upgrade (to 3.23.3 or higher)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we ensure that this temp exclusion gets removed? Do we have a good internal tracking mechanism?
How do we know that this may not introduce any other side effect? Any side effect that can be caused by excluding j2objc-annotations dependency? Or is this transitively getting included?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create a b ticket and internal note to track and ensure the release manager to remove this temp fix when protobuf upgrade for the shared-dependency. What do you think?
This is transitively included. In fact multiple dependency have it included. So after this exclusion, j2objc-annotations is still available via

[INFO] --< com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1 >--
[INFO] Building proto-google-cloud-spanner-admin-instance-v1 6.43.1-SNAPSHOT [2/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ proto-google-cloud-spanner-admin-instance-v1 ---
[INFO] com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] ---------< com.google.api.grpc:proto-google-cloud-spanner-v1 >----------
[INFO] Building proto-google-cloud-spanner-v1 6.43.1-SNAPSHOT            [3/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ proto-google-cloud-spanner-v1 ---
[INFO] com.google.api.grpc:proto-google-cloud-spanner-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] --< com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1 >--
[INFO] Building proto-google-cloud-spanner-admin-database-v1 6.43.1-SNAPSHOT [4/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ proto-google-cloud-spanner-admin-database-v1 ---
[INFO] com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] --< com.google.api.grpc:grpc-google-cloud-spanner-admin-instance-v1 >---
[INFO] Building grpc-google-cloud-spanner-admin-instance-v1 6.43.1-SNAPSHOT [5/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ grpc-google-cloud-spanner-admin-instance-v1 ---
[INFO] com.google.api.grpc:grpc-google-cloud-spanner-admin-instance-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] ----------< com.google.api.grpc:grpc-google-cloud-spanner-v1 >----------
[INFO] Building grpc-google-cloud-spanner-v1 6.43.1-SNAPSHOT             [6/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ grpc-google-cloud-spanner-v1 ---
[INFO] com.google.api.grpc:grpc-google-cloud-spanner-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] --< com.google.api.grpc:grpc-google-cloud-spanner-admin-database-v1 >---
[INFO] Building grpc-google-cloud-spanner-admin-database-v1 6.43.1-SNAPSHOT [7/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ grpc-google-cloud-spanner-admin-database-v1 ---
[INFO] com.google.api.grpc:grpc-google-cloud-spanner-admin-database-v1:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.guava:guava:jar:32.0.1-jre:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] ---------------< com.google.cloud:google-cloud-spanner >----------------
[INFO] Building Google Cloud Spanner 6.43.1-SNAPSHOT                     [8/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ google-cloud-spanner ---
[INFO] com.google.cloud:google-cloud-spanner:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.api.grpc:grpc-google-common-protos:jar:2.21.0:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile
[INFO] 
[INFO] -----------< com.google.cloud:google-cloud-spanner-executor >-----------
[INFO] Building Google Cloud Spanner Executor 6.43.1-SNAPSHOT            [9/10]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:3.5.0:tree (default-cli) @ google-cloud-spanner-executor ---
[INFO] com.google.cloud:google-cloud-spanner-executor:jar:6.43.1-SNAPSHOT
[INFO] \- com.google.http-client:google-http-client:jar:1.43.3:compile
[INFO]    \- com.google.j2objc:j2objc-annotations:jar:2.8:compile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thanks for the clarification and having this transitively included ensures there are no others side effects.
Yes, internal ticket works to track removing this workaround.

arpan14 deleted the shared-dep-updated branch

June 26, 2023 16:29

Labels

api: spanner

Issues related to the googleapis/java-spanner API.

size: s

Pull request size is small.

2 participants