feat: add tracing for batchUpdate, executeUpdate, and connections by olavloite · Pull Request #3097 · googleapis/java-spanner (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits19 Checks28 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

• Adds OpenTelemetry tracing to the Connection API. This again enables tracing in the JDBC driver and PGAdapter.
• Adds traces for batchUpdate calls in the Java client library (these calls were not traced).
• Adds traces for executeUpdate calls in the Java client library (these calls were not traced).
• Adds an option to include the actual SQL statement that was executed with the trace. This option is disabled by default. The option is named enableExtendedTracing, and might include additional features in the future.
• Adds the transaction tag and statement tag as attributes to the OpenTelemetry traces. This makes it easier to find traces for specific transactions and statements.

olavloite marked this pull request as ready for review

May 8, 2024 09:44

Create one combined option for extended tracing, and disable this option by default for both the Connection API and the standard client.

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

Done

olavloite changed the titlechore: add tracing to Connection API feat: add tracing to Connection API + tracing for batchUpdate and executeUpdate

May 14, 2024

olavloite changed the titlefeat: add tracing to Connection API + tracing for batchUpdate and executeUpdate feat: add tracing for batchUpdate, executeUpdate, and connections

May 14, 2024

Labels

api: spanner

Issues related to the googleapis/java-spanner API.

size: xl

Pull request size is extra large.