fix: AsyncTransactionManager did not always close the session by olavloite · Pull Request #3580 · googleapis/java-spanner (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits3 Checks28 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

olavloite

In a case where the following happens, the session that was used by an AsyncTransactionManager would not be returned to the pool:

  1. The transaction is abandoned without a Commit or Rollback call.
  2. The AsyncTransactionManager then executes a RollbackAsync internally.
  3. If the internal RollbackAsync failed, then the session would not be closed.

@olavloite

In a case where the following happens, the session that was used by an AsyncTransactionManager would not be returned to the pool:

  1. The transaction is abandoned without a Commit or Rollback call.
  2. The AsyncTransactionManager then executes a RollbackAsync internally.
  3. If the internal RollbackAsync failed, then the session would not be closed.

@olavloite

sakthivelmanii

rahul2393

@olavloite

@olavloite olavloite deleted the close-session-if-rollback-fails branch

January 3, 2025 12:51

Labels

api: spanner

Issues related to the googleapis/java-spanner API.

size: s

Pull request size is small.