.called_once() just returns a Mock, so assert .called_once() always passes. We want .assert_called_o...">

Correct schema write test by kiendang · Pull Request #1416 · graphql-python/graphene-django (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

kiendang

Discover this small "typo" while working on #1413.

<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once() always passes. We want <Mock>.assert_called_once().

firaskafri

@kiendang @ulgens

.called_once() just returns a Mock, so assert .called_once() always passes. We want .assert_called_once().

ulgens

ulgens

ulgens

superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request

Jul 19, 2023

@kiendang @superlevure

.called_once() just returns a Mock, so assert .called_once() always passes. We want .assert_called_once().