Add RFC 3986 support to DnsNameResolverProvider by jdcormie · Pull Request #12602 · grpc/grpc-java (original) (raw)
added 3 commits
Add examples to the getPathSegments() javadoc.
Introduce RFC 3986 concepts of absolute and rootless paths.
Update javadoc/tests to match reality w.r.t target URI path: path isn't actually the name to resolve, only the first path segment is actually used. This is a side effect of authority parsing later, in DnsNameResolver.java. Any additional path segments are silently ignored.
Replace discussion of the leading path / by making explicit the requirement that the input java.net.URI be hierarchical. This requirement isn't new -- checkNotNull(targetUri.getPath()) throws today if the target is opaque.
Also fix sloppy language in javadoc wrt service authority port: it isn't actually an input to the DNS layer, rather it's copied forward as a property of our output addresses at the io.grpc.NameResolver layer.
jdcormie changed the title
Add RFC 3986 support for 'dns' target URIs Add RFC 3986 support to DnsNameResolverProvider
jdcormie added a commit to jdcormie/grpc-java that referenced this pull request
github-actions Bot locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})