A80: Export TCP Telemetry from gRPC by AananthV · Pull Request #519 · grpc/proposal (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you understand why I'm looking at this so much more closely now vs before: Earlier this was "some metrics y'all wanted for yourselves". And I knew why you'd want them, and why they'd be useful to others, but there wasn't an idea we'd move quickly to implement this cross-language for wide availability. With the idea these are going to be on by default, that means these are seen as being more important/widely used metrics. They are now intended for the masses. Thus I started reviewing them as such.

Since I'm going to be unavailable next week: I'd said the comments I need to say. Once the threads are actually resolved (not just marked resolved), it seems it would be good to go.