Raise warning instead of error when imports are missing for custom code by DN6 · Pull Request #12513 · huggingface/diffusers (original) (raw)

What does this PR do?

check_imports in dynamic_module_utils doesn't account for guarded imports in custom code. Instead of diffusers raising an error, we should just raise a warning to let the user know that modules might be missing. The custom code will error out on loading anyway if a needed module is missing. We shouldn't raise errors on our side due inaccurate parsing/interpretation of the code.

This issue doesn't seem to happen when loading custom code directly from a local directory. I haven't investigated much further, but seems to imply that dynamic module loading might need a bit of work to be more robust/consistent.

Fixes # (issue)

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline?
• Did you read our philosophy doc (important for complex PRs)?
• Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.