📄 Renamed File for Better Understanding by kadirnar · Pull Request #4056 · huggingface/diffusers (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits6 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

kadirnar

@StevenLiu and @yiyixu

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

@kadirnar

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

@HuggingFaceDocBuilderDev

The documentation is not available anymore as the PR was closed or merged.

stevhliu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rl folder is supposed to be more general for reinforcement learning examples and "locomotion" is just an example of it. cc @patrickvonplaten who may have more insight

@pcuenca

I think @stevhliu is right, rl is meant to be "reinforcement learning" :)

@kadirnar

Renamed the 'rl' directory to 'reinforcement_learning'. This change provides a clearer understanding of the directory's purpose and its contents.

@kadirnar

patrickvonplaten

@kadirnar @patrickvonplaten

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

stevhliu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the last step is to update the link here since it'll break when the folder is renamed to reinforcement_learning.

patrickvonplaten

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevhliu

Ok for me as long as this link is also updated so nothing breaks :)

@kadirnar

@kadirnar

Ok for me as long as this link is also updated so nothing breaks :)

Sorry. I fixed it. Can you check?

@kadirnar

@kadirnar kadirnar deleted the feature/update-filename-run_locomotion branch

July 21, 2023 22:12

orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request

Aug 1, 2023

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

Renamed the 'rl' directory to 'reinforcement_learning'. This change provides a clearer understanding of the directory's purpose and its contents.

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request

Aug 1, 2023

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

Renamed the 'rl' directory to 'reinforcement_learning'. This change provides a clearer understanding of the directory's purpose and its contents.

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request

Aug 1, 2023

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

Renamed the 'rl' directory to 'reinforcement_learning'. This change provides a clearer understanding of the directory's purpose and its contents.

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request

Apr 26, 2024

@kadirnar @patrickvonplaten

Renamed the 'rl' file to 'run_locomotion'. This change was made to improve the clarity and readability of the codebase. The 'rl' name was ambiguous, and 'run_locomotion' provides a more clear description of the file's purpose.

Thanks 🙌

Renamed the 'rl' directory to 'reinforcement_learning'. This change provides a clearer understanding of the directory's purpose and its contents.

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com

Co-authored-by: Patrick von Platen patrick.v.platen@gmail.com