Allow passing different prompts to each text_encoder on stable_diffusion_xl pipelines by apolinario · Pull Request #4156 · huggingface/diffusers (original) (raw)

Design looks great, just added lots of comments as I think it's slightly more readable to just add prompts to zip instead of starting to index.

If you run make fix-copies all your changes should also be applied to the other SD-XL pipelines and then we only would have to add the names to the call function and some docstring

Finally could you also add a test here:

which can be very similar to this one:

def test_stable_diffusion_xl_offloads(self):

But instead of testing different offloads, we test that:
a) providing the same prompt to "prompt" and "prompt_2" and "negative_prompt" and "negative_prompt_2" gives the same results as just providing one prompt
b) that providing different prompts to each gives different results than just providing one

If you want we could also add a quick bullet point to the tips section here:

- Stable Diffusion XL output image can be improved by making use of a refiner as shown below.

saying that one can provide two prompts