diffusers (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits10 Checks18 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

What does this PR do?

This PR changes the video loading/export backends to imageio

imageio with ffmpeg loading and export allows videos to play on a larger number of platforms. It also appears less prone to codec issues than OpenCV.

Fixes # (issue)

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline?
Did you read our philosophy doc (important for complex PRs)?
Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
do we also need to add to the BACKENDS_MAPPING here?

BACKENDS_MAPPING = OrderedDict(

@DN6
ohh maybe let's keep the old code then?
we use imageio if is_imageio_available, otherwise, we use the old code, throw a warning that it might not work, and ask them to install imageio

yiyixuxu pushed a commit that referenced this pull request

Aug 24, 2024

update
update
update

Co-authored-by: Sayak Paul spsayakpaul@gmail.com

sayakpaul added a commit that referenced this pull request

Dec 23, 2024

update
update
update