a few fix for SingleFile tests by yiyixuxu · Pull Request #9522 · huggingface/diffusers (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits2 Checks18 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
| @@ -541,6 +542,7 @@ def infer_diffusers_model_type(checkpoint): |
|---|
| def fetch_diffusers_config(checkpoint): |
| model_type = infer_diffusers_model_type(checkpoint) |
| model_path = DIFFUSERS_DEFAULT_PIPELINE_PATHS[model_type] |
| model_path = copy.deepcopy(model_path) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making a copy that we won't accidently modify the DIFFUSERS_DEFAULT_PIPELINE_PATHS
so here is an example, we modified the output of fetch_diffusers_config in place
| subfolder = subfolder or config.pop( |
|---|
this is likely to happen if it had not already, so we should go through the single file code and see if there are more places might cause this type of errors
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great! Good to see a separate org for maintaining the runway checkpoints 🥹
I've been looking at some failing tests too (such as this, and similar) but cannot replicate locally either. Will take a deeper look at some of the remaining failing tests soon too
leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request
update sd15 repo
update more
sayakpaul pushed a commit that referenced this pull request
update sd15 repo
update more