Refac training utils.py by RogerSinghChugh · Pull Request #9815 · huggingface/diffusers (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits4 Checks15 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (make style, make quality, push changes) in #9724 but nothing seems to be working.
@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (
make style,make quality, push changes) in #9724 but nothing seems to be working.
Could be because of the versioning problems locally. I have just pushed the changed with "make style && make quality". Hopefully, that cuts it.
@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (
make style,make quality, push changes) in #9724 but nothing seems to be working.Could be because of the versioning problems locally. I have just pushed the changed with "make style && make quality". Hopefully, that cuts it.
Hi @sayakpaul
Thank you doing that. What do you mean by versioning changes? Do you mean the versions of the library ruff and isort I have installed?
I installed ruff 0.1.5 and the latest one for isort.
Can you let me know what versions are you running?
Also if the versioning is an issue, then can we add version requirements somewhere in the guides? Could be really helpful for beginners looking to contribute.
Once again thanks @stevhliu @sayakpaul
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sayakpaul added a commit that referenced this pull request
Refac training utils.py
quality
Co-authored-by: sayakpaul spsayakpaul@gmail.com