add intel xpu support for TGI by sywangyi · Pull Request #1475 · huggingface/text-generation-inference (original) (raw)
What does this PR do?
Fixes # (issue)
Before submitting
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline,
Pull Request section? - Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case. - Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings. - Did you write any new necessary tests?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Overall looks pretty good !
I think we'll move to propre enum SYSTEM instead of IS_XXXX since there's no way a user could be running 2 devices simultaneously. But we'll take care of that in a subsequent PR if that's OK.
@Narsil @OlivierDehaene I add xpu smi in env runtime, do you think is it proper to add this? this is to dump intel XPU version.
@Narsil @OlivierDehaene I add xpu smi in env runtime, do you think is it proper to add this? this is to dump intel XPU version.
It's OK in the current iteration (since showing N/A on most systems).
Feel free to open up the draft whenever you're OK so we can run the tests + merge.
@Narsil could you review the PR？done by my side.
@Narsil @mfuntowicz , pls feel free to let us know any issues, since CI is ready, I think we can launch CI and merge this PR, thx.
cc @kding1
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
Signed-off-by: Wang, Yi A yi.a.wang@intel.com
martinigoyanes pushed a commit to martinigoyanes/text-generation-inference that referenced this pull request
What does this PR do?
Fixes # (issue)
Before submitting
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline, Pull Request section?
- Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
- Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
- Did you write any new necessary tests?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Signed-off-by: Wang, Yi A yi.a.wang@intel.com Co-authored-by: Morgan Funtowicz funtowiczmo@gmail.com Co-authored-by: Nicolas Patry patry.nicolas@protonmail.com
Nilabhra pushed a commit to TII-AI-Research-Center/text-generation-inference that referenced this pull request
What does this PR do?
Fixes # (issue)
Before submitting
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline, Pull Request section?
- Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
- Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
- Did you write any new necessary tests?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Signed-off-by: Wang, Yi A yi.a.wang@intel.com Co-authored-by: Morgan Funtowicz funtowiczmo@gmail.com Co-authored-by: Nicolas Patry patry.nicolas@protonmail.com
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request
Fixes # (issue)
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline, Pull Request section?
- Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
- Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
- Did you write any new necessary tests?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Signed-off-by: Wang, Yi A yi.a.wang@intel.com Co-authored-by: Morgan Funtowicz funtowiczmo@gmail.com Co-authored-by: Nicolas Patry patry.nicolas@protonmail.com
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request
Fixes # (issue)
- This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- Did you read the contributor guideline, Pull Request section?
- Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
- Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
- Did you write any new necessary tests?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Signed-off-by: Wang, Yi A yi.a.wang@intel.com Co-authored-by: Morgan Funtowicz funtowiczmo@gmail.com Co-authored-by: Nicolas Patry patry.nicolas@protonmail.com